pcp
[Top] [All Lists]

Re: [pcp] pcp updates - patch to handle missing node-cpu mapping info on

To: pcp@xxxxxxxxxxx
Subject: Re: [pcp] pcp updates - patch to handle missing node-cpu mapping info on single CPU systems
From: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu, 22 Jan 2015 20:36:55 +1100
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <54C03FC5.3050902@xxxxxxxxxx>
References: <54C03FC5.3050902@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
On 22/01/15 11:09, Mark Goodwin wrote:

Debian verge 32bit systems (and possibly others) either don't fake a
numa node on single CPU systems, or don't export the node-cpu mapping
info in /sysfs. This was causing some buffer overrun issues found by
valgrind when hinv.nnode is zero but it was assumed to be at least one
on all systems.

I haven't committed this because I don't have a debian/i686 system
handy to test it on. I've only tested it on a fedora/4cpu/1node
system.

Thanks Mark.

I don't think the issue is debian/fedora related ... my first failing case I looked at was vm04 which is CentOS 5.11.

Anyway applying the patch to vm04 and remaking and installing the linux PMDA leads to qa/873 passing (which is good).

check -g pmda.linux also passes on vm04, which suggests no glaring regression at least for this one platform.

qa/873 was also failing for me on my Fedora20 platform (vm23).

After applying the patch there, qa/873 is passing now.

So, looks good to me.

<Prev in Thread] Current Thread [Next in Thread>