pcp
[Top] [All Lists]

Remove no-op code from linux_proc

To: pcp@xxxxxxxxxxx
Subject: Remove no-op code from linux_proc
From: Martins Innus <minnus@xxxxxxxxxxx>
Date: Fri, 05 Dec 2014 14:51:22 -0500
Delivered-to: pcp@xxxxxxxxxxx
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.2.0
Hi,
In my initial dynamic procs submission, I had a copy and paste error that didn't do anything. cgroups must have returned a value if the metrics makeup changed. Proc only returns non-zero when /proc can't be opened. From:

https://github.com/ubccr/pcp/tree/martins_working


commit 11c66bcde0ea263db7002d6731498f105dfb35bb
Author: Martins Innus <minnus@xxxxxxxxxxx>
Date:   Fri Dec 5 14:43:42 2014 -0500

    Remove noop code
In my initial dynamic proc refractor, I copied an unneccessary call that was in the cgroups code.
    For the procs case, it is not needed and never gets called.

 src/pmdas/linux_proc/pmda.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)


Thanks

Martins

<Prev in Thread] Current Thread [Next in Thread>
  • Remove no-op code from linux_proc, Martins Innus <=