On 11/19/2014 03:29 AM, Nathan Scott wrote:
> Hi David,
>
> ----- Original Message -----
>> On 11/17/2014 04:53 PM, Nathan Scott wrote:
>>> Oh, I just had the impression from your earlier mail you weren't
>>> completely satisfied that we'd covered off all the cases ... its
>>> likely I've just misinterpreted that "except for [1]" reference.
>>
>> I believe I've covered all the cases. All list/dictionary references are
>> cached down in cpmda and no longer thrown away after use (a). In the
>> PMDA class, I made sure all lists/dictionaries are cleared, not recreated.
>>
>
> OK, good stuff. Do you want to merge the PMDA API changes at this
> stage?
>
> I tried cherry-picking (there's lots of other commits in dsmith/dev):
> cec13bfd0297ecc755265ba2db69a86daf32a05c
> f2f5a51cde0646fcdf35bc2f60798024c0931c9e
> 1fc0bbf9d517810e8512fb3a7775b68fc6f64572
> ... but there was a fair few test failures (I haven't dug deeper yet -
> they all look like python PMDAs failing to start or exiting early on,
> from a quick glance).
Hmm, in theory these changes shouldn't effect existing python PMDAs.
I'll try to figure out how to run those tests and see what I get.
Let me do that before we merge the changes.
--
David Smith
dsmith@xxxxxxxxxx
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)
|