pcp
[Top] [All Lists]

Re: [pcp] [PATCH] Fix memory corruption in python support

To: pcp@xxxxxxxxxxx
Subject: Re: [pcp] [PATCH] Fix memory corruption in python support
From: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue, 07 Oct 2014 09:33:43 +1100
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <5432F280.20008@xxxxxxxxxx>
References: <542D6626.50703@xxxxxxxxxx> <336785285.60750380.1412287401855.JavaMail.zimbra@xxxxxxxxxx> <5432F280.20008@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2
On 07/10/14 06:50, David Smith wrote:
...

On the new pcpfans/dsmith/dev branch, there are 2 new commits:

- 44cb24d: This adds a new test (called '843') that can catch this bug.
Note that I based this test on an existing test, but I'm still not 100%
sure I updated the testsuite machinery properly. Also note that this new
test only tests the changes to src/python/pmda.c. I"m not really sure
how to test the changes to src/python/pmapi.c.

- 8e62465: This is the the python fix itself (that I posted to the list
earlier).

Thanks David.

I've cherry picked and confirmed ...
- qa/843 fails before the code change
- after the code change, debian builds are ok
- after the code change, qa/843 passes
- after the code change qa -g python passes

Integration of qa pieces looks OK to me also, except 843 probably should be in the python group as well (in qa/group) and I'll fix this in my next batch of commits.

Cheers, Ken.

<Prev in Thread] Current Thread [Next in Thread>