pcp
[Top] [All Lists]

Re: [pcp] [PATCH] Fix memory corruption in python support

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: Re: [pcp] [PATCH] Fix memory corruption in python support
From: David Smith <dsmith@xxxxxxxxxx>
Date: Mon, 06 Oct 2014 14:50:24 -0500
Cc: pcp <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <336785285.60750380.1412287401855.JavaMail.zimbra@xxxxxxxxxx>
References: <542D6626.50703@xxxxxxxxxx> <336785285.60750380.1412287401855.JavaMail.zimbra@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1
On 10/02/2014 05:03 PM, Nathan Scott wrote:
> Hi David,
>
> Can we distil that memory corruption into a reproducible test case?  We
> have several tests exercising various aspects of the PMDA wrapper but they
> are not triggering this problem - it'd be good to come up with something
> (e.g. minimal python script?) that demonstrates the problem and which we
> can use to verify the fix.

On the new pcpfans/dsmith/dev branch, there are 2 new commits:

- 44cb24d: This adds a new test (called '843') that can catch this bug.
Note that I based this test on an existing test, but I'm still not 100%
sure I updated the testsuite machinery properly. Also note that this new
test only tests the changes to src/python/pmda.c. I"m not really sure
how to test the changes to src/python/pmapi.c.

- 8e62465: This is the the python fix itself (that I posted to the list
earlier).

-- 
David Smith
dsmith@xxxxxxxxxx
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)

<Prev in Thread] Current Thread [Next in Thread>