Hi,
On 2014-10-03 07:27, Nathan Scott wrote:
>
> Looks good to me. Can you take a look over the pcp dev branch code, and
> verify everything is in order?
yes, looks good, although I wonder should Install/Remove scripts have
execution bit set in the repo already all will it be set when building /
packaging?
>> There is, however, one minor issue currently with the PMDA which I think I
>> should mention - it doesn't work :)
>
> Details, details. ;) I'll assume there's nothing we can do about this
> and it'll get fixed independently of any PCP use of the tool.
Yes, this is now being addressed in upstream:
https://fedorahosted.org/389/ticket/47910
>> To test this locally one would ideally have 389 DS running but testing
>> against a previously captured access log (e.g. from the above RHBZ) should
>> help to do basic sanity checking.
>
> Test qa/960 exercises the PMDA, optionally using this log now if no other
> is available. It all seems to be working nicely for me.
Thanks for the finishing touches. I'll certainly report if any
additional changes are needed once logconv.pl support is complete.
Cheers,
--
Marko Myllynen
|