pcp
[Top] [All Lists]

/prod/<pid>/stat additions

To: pcp developers <pcp@xxxxxxxxxxx>
Subject: /prod/<pid>/stat additions
From: Martins Innus <minnus@xxxxxxxxxxx>
Date: Mon, 22 Sep 2014 13:39:36 -0400
Delivered-to: pcp@xxxxxxxxxxx
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
Hi,
    I filled in missing fields from stat for the linux_proc_pmda:

*********

github.com/ubccr/pcp/tree/martins-working

*********
commit ed47714c15b254903e47d3b0dc45d04f030d7a78
Author: Martins Innus <minnus@xxxxxxxxxxx>
Date:   Mon Sep 22 13:08:27 2014 -0400

    Fill out remaining fields in /proc/<pid>/stat

    The following fields were added from stat:

    rt_priority
    policy
    delayacct_blkio_ticks
    guest_time
    cguest_time

 src/pmdas/linux_proc/help       |    5 ++++
src/pmdas/linux_proc/pmda.c | 46 +++++++++++++++++++++++++++++++++++++++
 src/pmdas/linux_proc/proc_pid.h |    7 +++++-
 src/pmdas/linux_proc/root_proc  |    5 ++++
 4 files changed, 62 insertions(+), 1 deletions(-)

*********

For most of the existing metrics from the stat file, there is 1-1 correspondence between the item id and its position in the buffer that is read from proc. But 3 existing metrics( ttyname, wchan_symbol, psargs) use ids that do not correspond to items in the buffer. So for the metrics i added, I just started after these and coded in the appropriate offset in the fetch. I assume messing with existing ids would break lots of existing archives, etc?

Also, I only needed delayacct_blkio_ticks for my purposes, but did the others just for completeness. Slightly off topic, but am I understanding correctly that delayacct_blkio_ticks would be a measure of per process IO wait?

Thanks

Martins

<Prev in Thread] Current Thread [Next in Thread>