Re: [pcp] [PATCH] Add NFS Server PMDA

[Marko Myllynen <myllynen@xxxxxxxxxx>]

Hi,

On 2014-09-19 09:43, Nathan Scott wrote:
> 
>> Please see below for an initial draft patch which adds currently the missing
>> metrics. But please note few things, perhaps you could help with these?
> 
> Sure thing ...

thanks!

>> pminfo can't find rpc.server.reqcounts{,3,4}, there's some code to populate
>> them but I'm not sure is the corresponding code in pmda.c correct. Also,
> 
> It looks like this is the nfs{,3,4}.server.reqs metrics ... they
> seem OK at first glance - were they too well hidden, or are they
> not working?

Right, they were "hidden" also in pminfo output - after reading the code
and looking how reqcounts arrays were populated I was looking for
reqcount instead reqs :) So they're all ok after all.

> Looks good to me - if you found 'em useful, lets go ahead and add the
> new metrics in.  I can see the few missing code spots so I'll do that
> on top of your patch.

Thanks,

-- 
Marko Myllynen