pcp
[Top] [All Lists]

Re: NSS/NSPR include file avoidance

To: Dave Brolley <brolley@xxxxxxxxxx>
Subject: Re: NSS/NSPR include file avoidance
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed, 7 Nov 2012 13:47:19 -0500 (EST)
Cc: pcp@xxxxxxxxxxx
In-reply-to: <509AA8A2.8010606@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>

----- Original Message -----
> On 11/07/2012 02:29 AM, Nathan Scott wrote:
> > Compile tested only at this stage ... keen to hear your thoughts
> > on this approach though & any review comments you might have on
> > this patch.  Thanks!
> >
> The goal of the patch and the methods used to achieve it are ok with
> me.
> I took a quick look at it and didn't spot anything obviously wrong
> (beyond what Frank found).
> 
> The branch is in a decent state with respect to fixes for running the
> the qa testsuite with NSS enabled. If you like, I'll apply the patch
> and shake out any problems.
> 

That'd be great, thanks.  I'll add those failure handling cases (looks
like there's a few littered around), and prepare a branch you could pull
from.

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>