pcp
[Top] [All Lists]

Incorrect handling of error codes from service discovery mechanisms

To: PCP Mailing List <pcp@xxxxxxxxxxx>
Subject: Incorrect handling of error codes from service discovery mechanisms
From: Dave Brolley <brolley@xxxxxxxxxx>
Date: Wed, 03 Sep 2014 16:36:23 -0400
Delivered-to: pcp@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0
While investigating RHBZ1136166, I noticed some incorrect handling of the return codes from __pmAvahiDiscoverServices() and __pmProbeDiscoverServices() within __pmDiscoverServicesWithOptions(). In particular, these return codes were not being checked to see if they were error codes before adding them to the accumulated number of urls.

Fixed by the following commit on the brolley/dev branch of pcpfans.

Dave

------------------------------------

commit 83167bf2d930b43cd7e0bef1c383370f6d895c7b
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Wed Sep 3 16:33:24 2014 -0400

    Incorrect handling of error codes from service discovery mechanisms.

    __pmDiscoverServicesWithOptions() was not checking whether the
    return codes from the discovery mechanisms were error codes before
    adding them to the accumulated number of urls.

<Prev in Thread] Current Thread [Next in Thread>
  • Incorrect handling of error codes from service discovery mechanisms, Dave Brolley <=