pcp
[Top] [All Lists]

Re: [pcp] qa/944: Race Condition With Respect to pmcd Startup

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: Re: [pcp] qa/944: Race Condition With Respect to pmcd Startup
From: Dave Brolley <brolley@xxxxxxxxxx>
Date: Mon, 18 Aug 2014 15:08:58 -0400
Cc: PCP Mailing List <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <780425511.30383608.1407991468157.JavaMail.zimbra@xxxxxxxxxx>
References: <53EBCFC4.9010405@xxxxxxxxxx> <780425511.30383608.1407991468157.JavaMail.zimbra@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0
On 08/14/2014 12:44 AM, Nathan Scott wrote:
Hmmm, could this be a bug in pmcd_wait?  It originally only knew about
ports/sockets, which either have-pmcd-actively-listening or they don't
... is it possible that pmcd_wait should gain more knowledge to deal
properly with AF_UNIX sockets?  e.g. does it fail early because a file
doesn't exist yet?  e.g. can we trap -ENOENT and continue trying like
we do for -ECONNREFUSED, or something like that, depending on what the
underlying issue here is?

on brolley/dev in pcpfans ...

commit 959000679811547d9c3857ed17d279aa1f0b99df
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:   Mon Aug 18 14:41:20 2014 -0400

    pmcd_wait now responds to ENOENT.

    ENOENT indicates that the pmcd's unix domain socket file has
    not yet been created. pmcd_wait will try again, up to the configured
    maximum number of times.

    This commit also reverts commit
    d62b31c5282c6133c87d067db28b3cd440f650f3 which is no longer
    necessary.

<Prev in Thread] Current Thread [Next in Thread>