On 07/14/2014 05:39 PM, Nathan Scott wrote:
is 192.168.122.1 - for the 775 and 946 failures).
I'm not quite sure what to do about these two failures. They are
actually a problem with the tests themselves. As part of these tests,
the -r and --resolve options to pmfind(1) are tested, however, in this
case, the address 192.168.122.1 is an address on which a legitimate
service has been discovered, but for which the DNS resolution fails.
Because of this, it is reported unresolved and the filters in the tests
report a failure. I'm not quite sure how else to test whether the -r and
--resolve options were respected.
Could we verify the state of each host identifier returned using dig and
dig -x? IOW, checking that those which can be resolved, are (comparing
libpcp and dig output), and those which cannot are not (pmfind vs dig -x)
brolley/dev in pcpfans ....
Dave
commit ceb06409cbbf4b7942c26713b1b7ac823bfa4810
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Tue Jul 15 15:47:38 2014 -0400
Add a filter for ignoring unresolvable addresses for service
discovery tests.
The new file qa/common.discovery contains a new filter,
_filter_discovery_unresolvable and moves other
common code from individual tests as _filter_discovery_sought,
_filter_discovery_resolved and _filter_discovery_unresolved.
The new file is sourced by tests 775 and 946 which are fixed
using the new _filter_discovery_unresolvable.
|