Re: [pcp] memcache pmda

[Chandana De Silva <chandana@xxxxxxxxxxxxx>]

Nathan,
I am sorry, but I did not get time to do the QA over the weekend. This 
week does not look good either
Chandana
On 11/07/14 15:51, Nathan Scott wrote:
> ----- Original Message -----
> > On 10/07/14 17:24, Nathan Scott wrote:
> > > Thanks for the offer Chandana!!!  You'll want to read qa/README to get a
> > > working test environment setup, and then we will need something like the
> > > script in qa/348 (which exercises pmdakvm) for exercising pmdamemcache.
> > I will take a look - probably over the weekend
> Thanks - please review test qa/835 if you get time?  (just a shell script)
>
> > > I notice there's a fair bit of commented-out code in pmdamemcache which
> > > I think maps to metrics we're not exporting yet - so there's scope for a
> > > bit of follow-up work here if you're interested Chandana, to export more
> > > memcached metrics than we have now - might be of use in your environment.
> > I saw that too. It does export a lot more so I will see if I can add
> > them later
> Good stuff.  The 835 test should automatically start exercising those metrics
> once they're added, I think.  Its a pretty simple test script anyway, would
> be easy to extend if it doesn't cover some of the new metrics (e.g. if there
> are new "stats xxx" commands to extract the data).
>
> cheers.
>
> --
> Nathan