pcp
[Top] [All Lists]

Re: [pcp] RFC - pmie "ruleset" extension

To: pcp@xxxxxxxxxxx
Subject: Re: [pcp] RFC - pmie "ruleset" extension
From: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue, 24 Jun 2014 14:09:38 +1000
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <53A8D578.90806@xxxxxxxxxx>
References: <53A8AA17.5070205@xxxxxxxxxxxxxxxx> <53A8AB4E.9090003@xxxxxxxxxxxxxxxx> <y0mtx7b5f7z.fsf@xxxxxxxx> <53A8D17C.8060808@xxxxxxxxxxxxxxxxxxx> <53A8D578.90806@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
On 24/06/14 11:33, Mark Goodwin wrote:
...
Not just messy, but rather inefficient and probably error prone too
because despite the repeated negation, the postfix.queues.* metrics
could change between the multiple rule evaluations (so more than one
rule could trigger). Actually - it depends on whether pmie does one
fetch per rule or one fetch per update cycle(?)

I think this is OK in the general case ... Frank's collapsing of the fetch groups makes it much more likely that multiple rules with the same sampling interval and metrics in common will see consistent values across all of the rules.

The ruleset builds a single expression tree to span all the rules, so this further enforces consistency for any metrics appearing in multiple rules and actions.

<Prev in Thread] Current Thread [Next in Thread>