Re: [pcp] PCP Updates: Active Probing for __pmDiscoverServices() / pmfind

[Dave Brolley <brolley@xxxxxxxxxx>]

On 05/22/2014 05:21 AM, Nathan Scott wrote:
> Hi Dave,
>
> ----- Original Message -----
> > Thanks for the reviews and suggestions. I'm in the process of going
> > though Nathan's comments and Frank's suggestion for an alternate
> > implementation. I will be responding shortly.
> No worries.  I followed through on my suggestion to add more than just
> one service to the set, so we can start to iron out issues there and to
> be sure the interfaces (& command) "fit" more than one OK ... could you
> review latest dev, which adds pmproxy & pmwebd advertising, and tweaks
> pmfind a bit? - that would be awesome, thanks.
I had a look. The diversification into additional services was handled 
as I had planned when originally designing the API.
The only problem I saw, and it was an existing problem, is that 
__pmAvahiDiscoverServices does not handle a NULL pointer passed in for 
'service'. This is the indication to discover all supported services and 
it is used by pmfind when "all" is specified.
I need to fix the same issue in __pmProbeDiscoverServices()

Dave