PCP Updates -- Remove inet-specific API Use in Favour of the libpcp I/O API

[Dave Brolley <brolley@xxxxxxxxxx>]

These commits, on the brolley/dev branch of pcpfans remove the use of inet-specific APIs (i.e. no ipv6) in favour of the libpcp I/O APIs (which do support IPv6, where available).

The original message from Nathan which inspired this can be found below.

Some __pm level functions which were previously static were moved to impl.h in order to accomplish this.

A local qa run shows no regressions.

Dave

------------------------------------------------------------------

commit fa6700099d746c3b72764de74d9606f7abe61505
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:ÂÂ Tue Apr 22 16:55:45 2014 -0400

ÂÂÂ Cisco PMDA: Use the __pm*() socket APIs throughout.

commit a08c81563dd4bb2b187ce8de9b364b2be2bf2789
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:ÂÂ Tue Apr 22 16:15:52 2014 -0400

ÂÂÂ src/telnet-probe/telnet-probe.c: Use the __pm*() socket APIs throughout.

commit a1920dec79e58eca519e3af62c1690242fc71d16
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:ÂÂ Tue Apr 22 15:26:18 2014 -0400

ÂÂÂ src/pmie/src/stomp.c: Use the __pm*() socket APIs throughout.

commit a7100289652d54661b1b40625e48fe902b9ad98e
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:ÂÂ Tue Apr 22 15:25:42 2014 -0400

ÂÂÂ Don't call __pmCloseSocket() on fds which indicate error (i.e. < 0).

commit 7bbc80366dddf9b9e38d50ba7ee4e467573ef7ca
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:ÂÂ Tue Apr 22 14:44:58 2014 -0400

ÂÂÂ http_fetcher.c: Use __pm*() socket APIs throughout.

commit a72b8b5dabf00148c2962ae90f81533a17041248
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:ÂÂ Tue Apr 22 12:12:55 2014 -0400

ÂÂÂ src/pmlogger/src/preamble.c: Use __pmgetAddrInfo()
ÂÂÂ
ÂÂÂ instead of gethostbyname().

commit ca59cbabb7e37e080c171fcb64e064b526ffdfdc
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:ÂÂ Fri Apr 18 14:34:11 2014 -0400

ÂÂÂ libpcp_trace/src/trace.c: Remove use of gethostbyname().
ÂÂÂ
ÂÂÂ Use __pm* I/O API throughout instead.

commit cc930ea1994d1d028a186520d789d2a61196009f
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:ÂÂ Mon Mar 31 11:47:45 2014 -0400

ÂÂÂ Fix typo in debugging message: gethostbyname -> __pmGetAddrInfo.

commit 5758ab54cffc4811b77d3092b2c2148f81ab0b31
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date:ÂÂ Mon Mar 31 11:37:52 2014 -0400

ÂÂÂ qa chkacc[123]: Remove references to inet_aton() and gethostbyname().
ÂÂÂ
ÂÂÂ Always use the __pmSockaddr* API.
ÂÂÂ Also removed PCP_VER checking throughout.

-------- Original Message --------

Subject:	IPv6 issues
Date:	Fri, 11 Oct 2013 01:45:46 -0400 (EDT)
From:	Nathan Scott <nathans@xxxxxxxxxx>
Reply-To:	Nathan Scott <nathans@xxxxxxxxxx>
To:	Dave Brolley <brolley@xxxxxxxxxx>

FYI - rpmdiff came up with this list of remaining IPv6 lurking issues.
Guess we should slowly clean these up over time?

cheers.



VERIFY	 	pcp	 	usr/bin/pmie on all architectures uses function gethostbyname, which may impact IPv6 support
VERIFY	 	pcp	 	usr/bin/pmlogger on all architectures uses function gethostbyname, which may impact IPv6 support
VERIFY	 	pcp	 	usr/libexec/pcp/bin/telnet-probe on all architectures uses function gethostbyname, which may impact IPv6 support
VERIFY	 	pcp	 	var/lib/pcp/pmdas/apache/pmdaapache on all architectures uses function gethostbyname, which may impact IPv6 support
VERIFY	 	pcp	 	var/lib/pcp/pmdas/cisco/parse on all architectures uses function gethostbyname, which may impact IPv6 support
VERIFY	 	pcp	 	var/lib/pcp/pmdas/cisco/pmdacisco on all architectures uses function gethostbyname, which may impact IPv6 support
VERIFY	 	pcp	 	var/lib/pcp/pmdas/cisco/probe on all architectures uses function gethostbyname, which may impact IPv6 support
VERIFY	 	pcp	 	var/lib/pcp/pmdas/linux/pmda_linux.so on all architectures uses function inet_ntoa, which may impact IPv6 support
VERIFY	 	pcp	 	var/lib/pcp/pmdas/linux/pmdalinux on all architectures uses function inet_ntoa, which may impact IPv6 support
VERIFY	 	pcp-libs	 	usr/lib/libpcp.so.3 on i686 ppc s390 uses function gethostbyname, which may impact IPv6 support
VERIFY	 	pcp-libs	 	usr/lib/libpcp.so.3 on i686 ppc s390 uses function inet_ntoa, which may impact IPv6 support
VERIFY	 	pcp-libs	 	usr/lib/libpcp_trace.so.2 on i686 ppc s390 uses function gethostbyname, which may impact IPv6 support
VERIFY	 	pcp-libs	 	usr/lib64/libpcp.so.3 on x86_64 ppc64 s390x uses function gethostbyname, which may impact IPv6 support
VERIFY	 	pcp-libs	 	usr/lib64/libpcp.so.3 on x86_64 ppc64 s390x uses function inet_ntoa, which may impact IPv6 support
VERIFY	 	pcp-libs	 	usr/lib64/libpcp_trace.so.2 on x86_64 ppc64 s390x uses function gethostbyname, which may impact IPv6 support


--
Nathan