Nathan,
On 2/7/14 5:41 AM, Nathan Scott wrote:
Hi Martins,
----- Original Message -----
Nathan,
Yes that would be great to get it in the tree. We are very interested in
these metrics and would look at getting it up and running.
OK, its merged now and disabled from packaging pending your review,
updating, testing & so on. Good luck, and have fun!
Thanks. Got it working with the attached patch. For now I just ignore
the statvers. Seems to give sane values on a simple nfs setup.
There have been several advances since that post too - the perl API
grew support for the pmdaCache routines that Max talks about there.
Also, python became an option for PMDAs in the interim - if someone
is keen to pick up those review comments and hack on this further,
might be worth considering that aspect too (python, too, can use the
pmdaCache APIs). An automated test to exercise the logic would be
a welcome addition as well (e.g. qa/553 "Exercise the gluster PMDA"
would make a good reference there).
So, you guide me - would it be helpful in the tree and not packaged
as Max suggested?
Is there an example perl pmda that uses pmdaCache that I could look at?
I probably don't have the time to rewrite in Python right now, but could
hack on the existing perl following Max's suggestions as I have time.
Thanks
Martins
nfsclient.patch
Description: Text document
|