On 12/13/2013 01:13 AM, Nathan Scott wrote:
Hi guys,
Just had a wander through current status of all your work
in git://sourceware.org/git/pcpfans.git fche/dev branch
(which contains Dave's too! yay, too easy).
I made a series of notes - a braindump follows, the files
were visited in no particular order so its a bit random.
Anyhow, its all looking pretty good to me and I'm looking
forward to trying it out. I'd really like other folks to
take a look too & offer their own review commentary also,
should they have time/inclination - thanks!
[ ... ]
[libpcp]
pmDiscoverServices -> numUrls += ... (else, no point assigning to zero)
Correct. When more discovery mechanisms are added it will become more
clear that each is intended to add to the list of discovered services.
internal.h - no need for new #ifdef there.
ok.
pmDiscoverServices needs a man page & automated QA (via pmfind perhaps).
Yeah. In the pipe.
[pmfind]
Default action is to do nothing? (make -p the default?, ie default
to pmcd service but allow cmdline option for others?)
Nope. The default is already -p. -p Seems redundant now, but would
eventually become necessary when other services become available to be
found.
Needs a man page & automated QA.
yup.
Dave
|