pcp
[Top] [All Lists]

pmdagfs2: misc updates

To: Nathan Scott <nathans@xxxxxxxxxx>, PCP Mailing List <pcp@xxxxxxxxxxx>
Subject: pmdagfs2: misc updates
From: Paul Evans <pevans@xxxxxxxxxx>
Date: Thu, 08 Aug 2013 17:05:37 +0100
Delivered-to: pcp@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
Changes committed to git://github.com/pauljevans/pcp.git dev

 qa/655.out                 |  1 +
src/pmdas/gfs2/help | 74 +++++++++++++++-------------------------------
 src/pmdas/gfs2/lock_time.c |  4 +--
 3 files changed, 27 insertions(+), 52 deletions(-)

commit 1e025a5b92063e1640dd34afb390c8bd4cad2fea
Author: Paul Evans <pevans@xxxxxxxxxx>
Date:   Thu Aug 8 16:55:58 2013 +0100

pmdagfs2: misc changes and alter glock_array size to PMDA_CACHE_SIZE_ACTIVE

    Made changes to the array size calculation in lock_time.c to allocate
only the number of active entries in the cache. An issue was found during
    testing where the allocated array size would be inflated because of
PMDA_CACHE_SIZE being used (culled but not yet reclaimed entries in the size count) instead of PMDA_CACHE_SIZE_ACTIVE resulting in an ever increasing
    allocation size for the array.

Extra check introduced in PMDA_CACHE_WALK to ensure return of only active
    entries as glock data from the current call should be returned.

    Made reductions to help text for gfs2.glock_lock_time metrics as they
    were a just a bit lengthy.

    Small amendment to 655.out to match an extra line of output that was
    not getting caught whilst checking qa/655.

<Prev in Thread] Current Thread [Next in Thread>