Hi Nathan,
On 07/17/2013 09:25 AM, Nathan Scott wrote:
Ah, OK - that sounds like a hole in the testing too.
Indeed, added some new tests to ensure that pmstore is checked in qa/655
It looks like the pmda will have to run privileged for now,
I shall roll back that last commit on my end.
OK. Also had a quick look over the other changes, and was a bit concerned
about the way output filtering has been removed in other areas - the loopN
change in particular, deals with non-determinism in the order of evaluation
of /dev/loop[01] - can that be either resolved differently if you want to
see the [01] part explicitly, or put back as it was perhaps?
There was also a bug introduced in the code that dealt with checking the
index into some arrays ... can you double check that? This was in the fetch
refresh code IIRC (don't have it handy atm) - there were checks on an array
index before accessing the array, and the new code added direct array lookup
before the check - which looked like a sigsegv candidate if the array index
passed in was invalid.
Both of these issues have been addressed and I have re-committed the
changes on my side along with the additional testing for pmstore.
Changes commited to git://github.com/pauljevans/pcp.git dev
qa/654 | 17 +-
qa/654.out | 541
---------------------------------------------
qa/655 | 30 ++-
qa/655.out | 6 +
qa/common.gfs2 | 33 ++-
src/pmdas/gfs2/glocks.c | 36 ++-
src/pmdas/gfs2/glstats.c | 36 ++-
src/pmdas/gfs2/lock_time.c | 2 +-
src/pmdas/gfs2/lock_time.h | 2 +-
src/pmdas/gfs2/pmda.c | 2 +-
src/pmdas/gfs2/sbstats.c | 20 +-
11 files changed, 122 insertions(+), 603 deletions(-)
commit fd475c958ec7bc91f38b57557e11210bcb1b58bb
Author: Paul Evans <pevans@xxxxxxxxxx>
Date: Wed Jul 17 11:15:53 2013 +0100
pmdagfs2: qa improvements to guarding and compatible setups
Have reduced the number of tests run on qa/654 so that it can be run
on most installations with gfs2-utils present. Checked against Fedora
16-19, Ubuntu 13.04, Centos 6.4 and Debian 7 with Debian 7 being the
most restrictive through only having support for gfs2.glock metrics.
Included additional checks in qa/655 to test for the mounting of
debugfs
and to attempt to mount it in the event that it is already not. Have
re-added added additional comments on suggestions how to quickly
setup a
configuration for testing 655 in qemu-kvm using the cbox application.
Added additional functions to common.gfs2 that test for the
availability of
mkfs.gfs2 on the test system (part of gfs2-utils) as well as
attempting to
mount debugfs on distributions that do not have it mounted by default.
qa/654.out reflects the changes made to qa/654 in order to verify a
correct
run.
Additional: Re-added non-deterministic view of loopN on tests in
qa/654 and
added pmstore checking in qa/655 to ensure the functionality is
checked in
future (testing gap).
commit de85a9fafabcc00b92c66f758758f12162278958
Author: Paul Evans <pevans@xxxxxxxxxx>
Date: Wed Jul 17 11:13:46 2013 +0100
pmdagfs2: Improvements for distributions without all gfs2 trace-points
Improved error handling for distributions that do not currently have
support for the full set of GFS2 trace-points.
Additional cases are used within all metrics fetch functions to check
for a pre-determined value which is set if the trace-point does not
exist on the system. This sets the metric values as "No Value(s)
Available" and is a cleaner output than zeros in these cases.
Also a little spring cleaning with some of the coding conventions.
Additional: Fixed issue where direct lookup without bounds check
could result in invalid array position being read.
Cheers,
Paul.
|