On 07/05/2013 02:20 AM, Nathan Scott wrote:
Nice work Dave! All merged in, and a few small tweaks here and there
in a follow-up commit - if you could double check those please, that'd
be great. Running it through QA now - haven't seen that permissions
issue you reported, so far, but I'll look into that if it crops up in
the remaining tests.
Thanks Nathan. I have reviewed your tweaks and they look ok to me. Thanks.
I am still seeing the permissions issue in my qa test runs and will look
into it today.
I've also added qa/875 which I think is exposing some issues (no .out
file yet as a result) - could you take a look at that for me while I'm
away next week? Thanks!!! Test 720 would be a good comparison point.
We may have a bit of work to do in __pmUnparseHostAttrsSpec still, and
there's lots of nasty looking errors from valgrind coming out the test
program (parsehostattrspec.c).
OK. I'll have a look at these as well.
Dave
|