pcp
[Top] [All Lists]

Re: [pcp] patch pcp-gui fix pmchart view save dialog

To: pcp@xxxxxxxxxxx, "fche >> \"Frank Ch. Eigler\"" <fche@xxxxxxxxxx>
Subject: Re: [pcp] patch pcp-gui fix pmchart view save dialog
From: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Thu, 11 Apr 2013 16:42:57 +1000
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <y0meheivu8a.fsf@xxxxxxxx>
References: <516562BE.5040401@xxxxxxxxx> <y0meheivu8a.fsf@xxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20130206 Thunderbird/14.0
On 04/11/2013 09:31 AM, Frank Ch. Eigler wrote:
Mark Goodwin <goodwinos@xxxxxxxxx> writes:

The pmchart view save dialog uses the wrong pointer value
when saving a view for metrics with a singular instance
domain.

My earlier ("Quite") patch fixes this more properly.  Can someone
review/merge it please?

finally found your pcp-gui tree hiding in the fche/pcp-gui branch
on pcpfans. For review it looks good. I'll build it and test it later
tonight (out of time right now) and if I get time will merge over
to the dev branch.

Another thing I've noticed is the pcp-gui specs need additional
BuildRequires for the new PM_CTXFLAG_* stuff. Something like :

BuildRequires: pcp >= 3.5.0, pcp-libs-devel >= 3.5.0

So I'll check that too.

Regards
-- Mark

<Prev in Thread] Current Thread [Next in Thread>