On 04/02/2013 06:09 PM, Ken McDonell wrote:
Dave,
Thanks for the pointer to the wrapper routine that I did not know about.
Your change looks good to me (and much cleaner) ... although the error
string needs a leading space and no trailing \n to fit in with the
surrounding fprintf's. And the loss of the unknown family=%d
diagnostic in the invalid address case is probably not an issue
(especially as it cannot be reported without exposing the conditional
mess you've just hidden behind the __pmSockAddrToString() call!).
Do you want to push this to Nathan, or would you like me to apply to
my tree and push back to the official tree that way?
I think it would be best for you to make the adjustments that you have
mentioned and apply to your tree. That way you can verify that the
output is as you expect before pushing it.
Thanks,
Dave
|