Re: [pcp] pcp updates

[Dave Brolley <brolley@xxxxxxxxxx>]

Hi Ken,

With respect to commit 4b69271ebe5847dc730a5135a2fd1318ee8770ee, the 
code for the { secure sockets enabled, secure sockets disabled } x { 
ipv4, ipv6 } mix is unnecessary. All you need to do is to call 
__pmSockAddrToString(saddr). It will take care of those details. It 
returns a pointer to a string from the heap, so you don't need to know 
the magic buffer size (46), but you do need to free it. You also do need 
to check that it is not NULL. If if is NULL then you can issue an error 
message.
Dave

On 04/02/2013 03:41 PM, Ken McDonell wrote:
> This mail was a bit delayed ... these were committed yesterday, and have 
> already been picked up in Nathan's latest merges into the official PCP tree.
>
> Changes committed to git://oss.sgi.com/kenj/pcp.git dev
>
>   Makepkgs                        |    3 +
>   qa/169                          |   41 ++++++++++++++++++++------
>   qa/462                          |   41 +++++++++++++++++++++-----
>   qa/admin/check-vm               |   17 +++++++++-
>   qa/common.secure                |    2 +
>   qa/qa_hosts.master              |    1
>   src/libpcp/src/internal.h       |    1
>   src/libpcp_pmcd/src/GNUmakefile |    6 +++
>   src/libpcp_pmcd/src/trace.c     |   62 
> +++++++++++++++++++++++++++++-----------
>   src/pmcd/src/client.c           |   17 +++++++---
>   src/pmcd/src/client.h           |    5 +--
>   11 files changed, 152 insertions(+), 44 deletions(-)
>
> commit 4b69271ebe5847dc730a5135a2fd1318ee8770ee
> Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
> Date:   Tue Apr 2 13:42:30 2013 +1100
>
>      pmcd client connection tracing, qa/169
>      
>      Fix for failing qa/169 which involved an unintended DNS timeout
>      in gethostbyaddr() at a critical point in the concurrent timeout
>      handling for both a failing PMDA and a client request.
>      
>      In pmcd, do not do reverse DNS lookups for trace diagnostic,
>      report IP addr only.  Also rework this code to handle the mix
>      { secure sockets enabled, secure sockets disabled } x { ipv4, ipv6 }.
>      
>      Involves exposing the internals of pmcd's ClientInfo struct to
>      libpcp_pmcd, and getting some of the internal socket state from
>      libpcp visible in libpcp_pmcd.
>
> commit 75ca0ce763b62d161cc19e61f14d5575d2976eac
> Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
> Date:   Sun Mar 31 07:33:46 2013 +1100
>
>      qa/admin - more /etc/hosts sniffing for check-vm
>
> commit 4d52928fe7de261b22736443747949c99d160c5e
> Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
> Date:   Sun Mar 31 07:32:21 2013 +1100
>
>      qa/common.secure - include ascii certificate in *.full
>      
>      Just being paranoid in my attempts to debug the failing 71? tests
>      ... but this may be useful at some point in the future.
>
> commit 1a16f430ffde5ac14ffe69e3d021182f97e6beb0
> Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
> Date:   Sun Mar 31 07:28:27 2013 +1100
>
>      Makepkgs - make mini-clean substitute
>      
>      There are _some_ artifacts left in the workarea (especially after
>      a QA run) that can break a following Makepkgs run, e.g. qa/qa_outfiles.
>      
>      This commit provides a place for dealing with these, without requiring
>      a make clean (which obliterates things that take a long time to
>      recreate the next time you run QA).
>
> commit 65b1c6d8ba9bf98c986c667e2e95f9cc69e43a84
> Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
> Date:   Sun Mar 31 07:27:43 2013 +1100
>
>      qa_hosts.master - add host emma for kenj
>
> commit fb2240c55b229e57d182478c5e8f602a17eb43e6
> Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
> Date:   Sun Mar 31 07:23:20 2013 +1100
>
>      qa/462 - fix nasty race condition
>      
>      Between tests 4 and 5 there was the possibility for a nasty
>      (i.e. very hard to debug) race between the backgrounded pmcd
>      stop and the following pmcd start in the foreground.
>      
>      Added a timed semaphore using a temporary file and improved the
>      diags sent to 462.full.
>
> _______________________________________________
> pcp mailing list
> pcp@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/pcp