Changes committed to git://oss.sgi.com:8090/nathans/pcp.git
VERSION.pcp | 2 -
src/pmdas/linux/GNUmakefile | 2 -
src/pmdas/linux/convert.h | 49
++++++++++++++++++++++++++++++++++++++
src/pmdas/linux/pmda.c | 40 +++++--------------------------
src/pmdas/linux/proc_partitions.c | 28 ++++++++++++---------
src/pmdas/linux/proc_partitions.h | 12 ++++-----
src/pminfo/GNUmakefile | 1
src/pmprobe/GNUmakefile | 1
8 files changed, 82 insertions(+), 53 deletions(-)
commit 74b541abe48edf10121f2bb4e065a433086be672
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed Feb 6 15:46:31 2008 +1100
Bump build number.
commit 71dfa40031b76a85d5053e2e9dc06c3091aaaf9b
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed Feb 6 13:44:58 2008 +1100
Enable local context mode in pminfo and pmprobe.
commit 89dcfbda7e2415222ad38fe21a5611429d4c1228
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed Feb 6 13:42:41 2008 +1100
Fix a bug with the disk statistics in the Linux PMDA. The sizes
and signedness of the sprintf format and several of the fields of
the per-device structure did not match the kernel, and did not
cater for differences between 32 and 64 bit longs.
Initially observed as disk read/write_bytes and blkread/write on
one of our product NAS servers not being updated - this turned out
to be due to using signed vs unsigned integers in a sprintf. The
fix was verified on the same machine:
~$ pminfo -f disk.dev.blkread
disk.dev.blkread
inst [3 or "sdc"] value 2147483647
~$ gdb -q
(gdb) p /x 2147483647
$1 = 0x7fffffff
~$ pminfo -f disk.dev.blkread
disk.dev.blkread
inst [3 or "sdc"] value 3247668682
$ gdb -q
(gdb) p /x 3247668682
$1 = 0xc1937dca
|