pcp
[Top] [All Lists]

Re: [pcp] coding issues and defects uncovered by Coverity scans

To: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Subject: Re: [pcp] coding issues and defects uncovered by Coverity scans
From: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Mon, 30 Jan 2012 22:53:13 +1100
Cc: Nathan Scott <nathans@xxxxxxxxxx>, pcp <pcp@xxxxxxxxxxx>
In-reply-to: <1327917662.4313.4.camel@xxxxxxxxxxxxxxxx>
References: <1793700059.46983.1326419918854.JavaMail.root@xxxxxxxxxxxxxxxxxxxxxx> <4F109D6B.5070808@xxxxxxxxxx> <1327917662.4313.4.camel@xxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0
On 01/30/2012 09:01 PM, Ken McDonell wrote:
On Sat, 2012-01-14 at 08:08 +1100, Mark Goodwin wrote:
...

Which leaves the following still up for grabs :

$ awk '/UNINSPECTED/&&  $3 !~ "/libpcp/"&&  $3 !~ "/src/pmdas/" {print $1}'
pcp-cov-nathan.txt | fmt
1 2 3 9 11 12 17 24 28 29 34 38 39 40 41 42 45 46 47 49 52 53 54 55 56
57 58 61 63 64 65 70 71 74 76 78 79 85 86 87 88 89 92 93 94 96 97 106
107 108 110 111 112 114 122 123 138 143 145 150 151 152 157 158 159 162
167 168 169 170 171 175 176 177 179 182 184 185 186 187 188 192 193 194
195 197 198 199 200 201 202 203 205 206 207 208 209 210 211 213 214 215
218 219 220 222 223 225 228 231 232 236 237 239 240 241 243 244 246 249
250 252 253 254 255 258 260 261 262 263 264 265 266 273 274 275 279 280
281 282 283 284 285 286 287 293 294 295 296 297 300 302 303 306 308 314
315 317 318 319 320 322 323 324 326 328 329 330 331 332 334 336 340 341
344 346 348 351 352 353

Since we seem to have a shortage of grabbers (!), I've grouped the
remaining ones by source code directory and counted the issues in each,
so we have ...

  1 libpcp_gui
  1 libpcp_mmv
  1 libpcp_pmcd
  1 newhelp
  1 pmcpp
  1 pmstat
  2 libpcp_import
  2 pmns
  3 pmevent
  3 pminfo
  4 cpan
  4 pmdumplog
  5 libpcp_trace
  5 pmlc
  6 libpcp_http
  8 pmlogreduce
  9 pmcd
  9 pmlogsummary
10 pmval
11 libpcp_pmda
13 pmlogextract
13 pmlogger
18 dbpmda
19 pmie
21 pmieconf
22 pmlogrewrite

I'll start working on these in order of importance, so pmcd, then
pmlogger and then pmie.

If anyone wants to do some, mail the list and I'll take 'em off the list
above.

Ok for my next batch I'll take :

   1 libpcp_gui
   1 libpcp_mmv
   1 libpcp_pmcd
   1 newhelp
   1 pmcpp
   1 pmstat
   2 libpcp_import
   2 pmns
   3 pmevent
   3 pminfo
   4 cpan
   4 pmdumplog
   5 libpcp_trace
   5 pmlc
   6 libpcp_http
   8 pmlogreduce

So that leaves the following still for grabs:

  9 pmlogsummary
 10 pmval
 11 libpcp_pmda
 13 pmlogextract
 18 dbpmda
 21 pmieconf
 22 pmlogrewrite

BTW Ken, didn't get a chance to review your libpcp analysis (#30, #32,
#325, #327, #337, #345, #349 and #350) today - hopefully tomorrow.

Cheers
-- Mark

<Prev in Thread] Current Thread [Next in Thread>