Changes committed to git://oss.sgi.com/markgw/pcp/pcp.git dev
pulled from Nathan's tree, and then committed the following
in my tree. See next message re: Coverity notes.
commit 538df34b5cf9e3ef927ac91056c3046aa9e2ec88
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Tue Jan 17 10:48:22 2012 +1100
Fixed ptr references to an out of scope variable.
modified: src/pmdas/trace/src/trace.c
commit 5bad75a77ccdc1ade91f450100ef90cff8c1d110
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Tue Jan 17 10:41:46 2012 +1100
delete unused variable.
modified: src/pmdas/linux/proc_pid.c
commit e8ab89bfe839a30eb38f0ff2713f52c976bf096a
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Tue Jan 17 08:44:02 2012 +1100
Fix typo causing build error.
modified: src/pmdas/cisco/probe.c
commit 60160b0256b119e80226a8fb8db1a42f7d462794
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Mon Jan 16 17:56:18 2012 +1100
fclose file pointer in err handling path to avoid mem leak
modified: src/pmdas/linux/ksym.c
commit f9db46f0edc667414e838c54cf3daf2061b92576
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Mon Jan 16 17:50:14 2012 +1100
correctly close file pointer in err handling paths to plug memory leak
modified: src/pmdas/linux/proc_slabinfo.c
commit 37f3e00f225985c54d954d2d1331e86652c360bc
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Mon Jan 16 17:41:55 2012 +1100
fclose the file pointer in do_sendmail_cf(0 to avoid memory leak.
modified: src/pmdas/sendmail/sendmail.c
commit d4ea1c98fbeb39e9fa8849a619b014671cc6dabb
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Mon Jan 16 17:28:06 2012 +1100
fclose fspec in err handling paths to avoid memory leak
modified: src/pmdas/sample/src/sample.c
commit 95f3c1849f7fe8e1fc41b4413997bd9e4977d9e3
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Mon Jan 16 16:46:23 2012 +1100
fclose the iosucker stream befoe returning - plugs a memory leak.
modified: src/pmdas/trace/app2.c
modified: src/pmdas/trace/app3.c
commit 3171338c339f59c1bb724ee234c3a74555738b81
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Mon Jan 16 16:40:16 2012 +1100
fclose file in error handling path to plug a leak
modified: src/pmdas/linux/proc_net_tcp.c
commit 3160e454f088c848a4e7f7bbfe4a0c1e61343500
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Mon Jan 16 16:36:56 2012 +1100
pmdaCacheStore() .. store() .. insert_cache() makes it's own strdup of name
so passing a strdup'd name to pmdaCacheStore and not freeing it is a leak.
modified: src/pmdas/linux/cgroups.c
commit 6c2709aff6abf2d4856f8d9c74bc6e7a1819cd73
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Mon Jan 16 15:41:40 2012 +1100
Fix minor memory leak in error handling path.
modified: src/pmdas/trace/src/pmda.c
commit e9f2255c3b28dad71929e1ecbb076b6822fd661e
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Mon Jan 16 15:35:25 2012 +1100
Fix memory leak in error handling path.
modified: src/pmdas/linux/cgroups.c
commit e55684b74c814268427946d9bff4e8e850b526e5
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Mon Jan 16 15:18:01 2012 +1100
Only close(fd) if it's valid.
modified: src/pmdas/linux/proc_pid.c
commit dad59809887c88f99b473e6826b27cdb7983b01c
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Mon Jan 16 14:23:25 2012 +1100
Fix inverted logic for closing the log fd.
modified: src/pmdas/logger/event.c
commit bc675af185bfcf684105702d21222121e93aec6e
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Mon Jan 16 14:19:01 2012 +1100
check return of dup() before passing to fdopen()
modified: src/pmdas/cisco/telnet.c
commit 141e27547f3e66ff73120f6d89d1639a4d5adc49
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Mon Jan 16 14:15:18 2012 +1100
Check return of dup() before passing to fdopen().
modified: src/pmdas/cisco/probe.c
commit 1fce615be97a0da2654a7a9d6eea4e9dc81260a1
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Mon Jan 16 14:08:30 2012 +1100
Fixed a poorly defined macro in weblog.h and incorrect formatting in
weblog.c
modified: src/pmdas/weblog/weblog.c
modified: src/pmdas/weblog/weblog.h
commit c6581fce42234935421440ba189a55e33f076ac4
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Sat Jan 14 10:36:34 2012 +1100
Add missing break (benign).
modified: src/pmdas/sample/src/sample.c
commit 7875064dc72e676ec6fab8aa3a0ce9868133169a
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Sat Jan 14 09:47:30 2012 +1100
Make sure the partition instance was found earlier.
modified: src/pmdas/linux/proc_partitions.c
commit 77abd89520af7386535a1f13e2e0b28a168b9b5b
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Sat Jan 14 09:30:04 2012 +1100
Check datap buffer isn't NULL before reading into it.
modified: src/pmdas/lustrecomm/refresh_file.c
commit 6c60b8c277af0249b5bc9e3eede28fef1666b416
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Sat Jan 14 09:27:11 2012 +1100
Check return value for fstat.
modified: src/pmdas/logger/event.c
modified: src/pmdas/mmv/mmvdump.c
|