pcp
[Top] [All Lists]

Re: [pcp] coding issues and defects uncovered by Coverity scans

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: Re: [pcp] coding issues and defects uncovered by Coverity scans
From: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Fri, 13 Jan 2012 11:31:24 +1100
Cc: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>, pcp <pcp@xxxxxxxxxxx>
In-reply-to: <258201772.46774.1326413265675.JavaMail.root@xxxxxxxxxxxxxxxxxxxxxx>
References: <258201772.46774.1326413265675.JavaMail.root@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0
On 01/13/2012 11:07 AM, Nathan Scott wrote:


----- Original Message -----
On Thu, 2012-01-12 at 21:50 +1100, Nathan Scott wrote:
Hi Ken,
...

OK, I've looked at a few more cases at random ... and there are enough
real issues here to warrant a quick pass and fix if obviously broken.

yeah, I think your initial choice of interp.c cases was unfortunate ;)


We do need some global assignment of the 353 cases to avoid stepping
on
one another's toes.

If I might suggest splitting by code area, I could start on the libpcp
ones.

ok so that'd be :

16 26 27 30-33 35 36 43 44 50 60 62 66-69 73 84 90 91 98 100 105 109 113
115 124 128 129 132 133 144 147 153 155 156 161 163-166 172-174 178 181
189 196 204 212 216 217 221 229 230 233-235 242 247 256 257 276 277 298
307 316 325 327 337 342 343 345 347 349 350


I've pushed most of what I had into a dev branch of my tree ... I have a
half finished list of which of the issues this addresses, but have to run
to a meeting - will get that to ya later today&  we can divvy up further.

Will have to wait for Nathan to get back with his list of what's already
been done.

I'd take on pmdas/linux and libpcp_pmda, subject to what Nathan has already
worked on ... so wont start on it just yet then.

If any of these issues seems non-obvious or a false positive etc, then
just skip it and we can run another scan later - I think I can probably
get access to Coverity internally here at RH.

Regards
-- Mark

<Prev in Thread] Current Thread [Next in Thread>