pcp
[Top] [All Lists]

Re: [pcp] draft pmval event support patch

To: kenj@xxxxxxxxxxxxxxxx
Subject: Re: [pcp] draft pmval event support patch
From: David Smith <dsmith@xxxxxxxxxx>
Date: Tue, 01 Mar 2011 16:47:53 -0600
Cc: pcp@xxxxxxxxxxx
In-reply-to: <1299010797.21904.40.camel@xxxxxxxxxxxxxxxx>
References: <4D6D0D30.2060507@xxxxxxxxxx> <1299010797.21904.40.camel@xxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.7
On 03/01/2011 02:19 PM, Ken McDonell wrote:
> On Tue, 2011-03-01 at 09:13 -0600, David Smith wrote:
>> Since I'm working on a PMDA that supplies event records, I really needed
>> pmval to have event support.  So, I stole the support from pminfo and
>> threw it into pmval.  I've attached the patch I used.  This is a draft
>> patch, since I know it needs to be improved.  This is (hopefully) a
>> starting point.
>>
> David,
> 
> I wonder if it would be better to simply gut pmval to create a new tool
> specifically for event records ... a fair amount of what pmval does is
> not going to be very useful (I suspect) for event records, e.g.
> ...

That's fine with me (I certainly don't have a good feel at all for pcp's
big picture).

> So we'd end up with something with a usage like ...
> 
> Usage: pmevent [options] [metricname ...]
> 
> Options:
>   -A align      align sample times on natural boundaries
>   -a archive    metrics source is a PCP log archive (interpolate values)
>   -g            start in GUI mode with new time control
>   -h host       metrics source is PMCD on host
>   -i instance   metric instance or list of instances - elements in an
>                 instance list are separated by commas or whitespace
>   -K spec       optional additional PMDA spec for local connection
>                 spec is of the form op,domain,dso-path,init-routine
>   -O offset     initial offset into the time window
>   -p port       port number for connection to existing time control
>   -S starttime  start of the time window
>   -s samples    terminate after this many samples
>   -T endtime    end of the time window
>   -t interval   sample interval [default 1 second]
>   -Z timezone   set reporting timezone
>   -z            set reporting timezone to local time of metrics source
> 
> So I'd be inclined to apply your patch, copy the pmval subdirectory and
> fire up the chain saw.

Seems reasonable.

-- 
David Smith
dsmith@xxxxxxxxxx
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)

<Prev in Thread] Current Thread [Next in Thread>