pcp
[Top] [All Lists]

Re: [pcp] "Pretty" disk names on Solaris

To: Max Matveev <makc@xxxxxxxxx>
Subject: Re: [pcp] "Pretty" disk names on Solaris
From: Greg Banks <gnb@xxxxxxxxxxx>
Date: Wed, 15 Sep 2010 13:26:06 +1000
Cc: "pcp@xxxxxxxxxxx" <pcp@xxxxxxxxxxx>
In-reply-to: <19599.3281.174305.38380@xxxxxxxxxxxx>
References: <19599.3281.174305.38380@xxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.23 (X11/20090817)
Max Matveev wrote:
Greg,

Can you take a look at this change - the code is convoluted and I'm
not sure I've got it right.

max

The following changes since commit
6eec8fa53fe16fb520bfb814fd45a1dd3c538afa:
  Max Matveev (1):
        Make sure that kstat chains are updated for each fetch request

are available in the git repository at:

  git://oss.sgi.com/makc/pcp devlink


+           if (minor == DI_MINOR_NIL) {;

The extra ; is wrong but harmless.

Nothing else obvious stares out at me, but I'll need to go and familiarise myself with the libdevinfo API.

--
Greg.

<Prev in Thread] Current Thread [Next in Thread>