On 07/22/2010 05:07 PM, Ken McDonell wrote:
All the core work is done here now.
looking great Ken.
Check out src/pcp/pmimport/demos/sar2pcp to see a real example of how
this could be used (the README there gives a better overview than
scanning 600+ lines of Perl).
I'll give this a whirl .. way too much sar data floating around
where I lurk, so this will be a godsend :)
I have not yet decided what to do about pmimport per se (a driver
maybe), and I need some advice on how to package sar2pcp as it involves
dependencies on a number of Perl modules that are from CPAN, not from
PCP.
For packaging, I'd suggest we do this :
libpcp_import.so goes into pcp-libs
man/man3/*.3 and import.h go into pcp-libs-devel
(and maybe rename import.h to pmimport.h ??)
Nathan mentioned both of the above will probably Just Work
for the RPM packaging, since the debian packaging lists
have already been updated.
Everything else, including the pmimport driver and pmimport.1
go into a new package called perl-PCP-LogImport, which can
have whatever perl dependencies are required. The sar2pcp
script could be packaged in perl-PCP-LogImport too (as a
proper utility, not as a demo). Not sure about the dependency
between sar2pcp and the sysstat package (run-time checks
may suffice here?).
We bump to 3.4.0 since there are new APIs being shipped.
Sound reasonable?
Cheers
-- Mark
Have fun.
Changes committed to git://oss.sgi.com/kenj/pcp.git dev
man/man3/GNUmakefile | 6
man/man3/logimport.3 | 110 ++++++
man/man3/mmv_inc_value.3 | 1
man/man3/mmv_lookup_value_desc.3 | 1
man/man3/mmv_stats_init.3 | 1
man/man3/pmiaddinstance.3 | 84 +++++
man/man3/pmiaddmetric.3 | 126 +++++++
man/man3/pmidstr.3 | 2
man/man3/pmiend.3 | 59 +++
man/man3/pmierrstr.3 | 67 ++++
man/man3/pmigethandle.3 | 81 ++++
man/man3/pmindomstr.3 | 2
man/man3/pmiputresult.3 | 84 +++++
man/man3/pmiputvalue.3 | 88 +++++
man/man3/pmiputvaluehandle.3 | 74 ++++
man/man3/pmisethostname.3 | 57 +++
man/man3/pmisettimezone.3 | 57 +++
man/man3/pmistart.3 | 139 ++++++++
man/man3/pmiunits.3 | 61 +++
man/man3/pmiusecontext.3 | 62 +++
man/man3/pmiwrite.3 | 71 ++++
src/cpan/LogImport/LogImport.pm | 36 ++
src/cpan/LogImport/MANIFEST | 1
src/cpan/MMV/MMV.pm | 3
src/libpcp/src/logutil.c | 9
src/libpcp_import/src/GNUmakefile | 2
src/libpcp_import/src/import.c | 65 ++--
src/libpcp_import/src/private.h | 1
src/libpcp_import/src/stuff.c | 6
src/pmimport/demos/sar2pcp/README | 81 ++++
src/pmimport/demos/sar2pcp/sar2pcp | 600
+++++++++++++++++++++++++++++++++++++
src/pmns/stdpmid.pcp | 2
32 files changed, 1999 insertions(+), 40 deletions(-)
...
|