pcp
[Top] [All Lists]

Re: [PATCH] respect configured prefix instead of hardcoded /etc

To: James Peach <jamespeach@xxxxxxx>
Subject: Re: [PATCH] respect configured prefix instead of hardcoded /etc
From: Mark Goodwin <markgw@xxxxxxx>
Date: Fri, 04 Apr 2008 14:56:37 +1100
Cc: Max Matveev <makc@xxxxxxx>, pcp@xxxxxxxxxxx
In-reply-to: <03ADE2A4-AAD6-4C8B-850D-1352D5D4C7DC@mac.com>
Organization: SGI Engineering
References: <7BE130C4-F6A6-428D-82D5-A7D7EE399E87@mac.com> <18421.26341.981959.130522@kuku.melbourne.sgi.com> <03ADE2A4-AAD6-4C8B-850D-1352D5D4C7DC@mac.com>
Reply-to: markgw@xxxxxxx
Sender: pcp-bounce@xxxxxxxxxxx
User-agent: Thunderbird 1.5.0.14 (Windows/20071210)


James Peach wrote:
On 03/04/2008, at 4:23 PM, Max Matveev wrote:
On Thu, 3 Apr 2008 13:26:32 -0700, James Peach wrote:

JP> commit f3d97e64f2774ea4414c0556e17d7fdd83e30df6
JP> Author: James Peach <jpeach@xxxxxxxxx>
JP> Date:   Thu Apr 3 13:22:11 2008 -0700

JP>      Use the prefix-relative etc directory instead of harcoding /etc.

JP> diff --git a/GNUmakefile b/GNUmakefile
JP> index a945efd..077f105 100644
JP> --- a/GNUmakefile
JP> +++ b/GNUmakefile
JP> @@ -104,6 +104,7 @@ endif
JP>       $(INSTALL) -m 755 -d $(PCP_SHARE_DIR)/lib
JP>       $(INSTALL) -m 755 -d $(PCP_SHARE_DIR)/examples
JP>       $(INSTALL) -m 755 -d $(PCP_INC_DIR)
JP> +    $(INSTALL) -m 755 -d $(PCP_ETC_DIR)
That would make pcp the owner of /etc on Linux:

Then shouldn't $(INSTALL) specify the owner and group?

I don't think you want to change user/group for /etc, nor do we want /etc to be owned by both the 'filesystem' package and pcp.

pcp does not have its
own /etc/pcp directory and splats its files around the shared
directory.

ick :)

We could move all this stuff into an /etc/pcp directory if that would be more palatable. But it won't be easy.

Also, /etc/pcp.conf is hardcoded deliberately to avoid chicken'n'egg
problem finding the source of information about relocation which can
be relocatable itself.

So does this only apply to pcp.conf? It seems like the build hardcodes all the config files to go into /etc ...

Actually, it only applies to /etc/pcp.env. The location of pcp.conf is controlled by $PCP_CONF in the environment.

I'm trying to gradually teach PCP not to blat itself all over my filesystem when I give configure the --prefix option. I'm very happy to take advice ....

It's painful but doable. Keep plugging away ... :)

Cheers
-- Mark



<Prev in Thread] Current Thread [Next in Thread>