pcp
[Top] [All Lists]

Re: PCP start/stop script regression

To: nscott@xxxxxxxxxx
Subject: Re: PCP start/stop script regression
From: Mark Goodwin <markgw@xxxxxxx>
Date: Fri, 25 May 2007 13:26:51 +1000
Cc: kimbrr@xxxxxxx, pcp@xxxxxxxxxxx
In-reply-to: <1180062348.6273.575.camel@edge>
Organization: SGI Engineering
References: <1180062348.6273.575.camel@edge>
Reply-to: markgw@xxxxxxx
Sender: pcp-bounce@xxxxxxxxxxx
User-agent: Thunderbird 1.5.0.10 (Windows/20070221)
Hi Nathan, yes that's definitely a regression; we'll get it
fixed and spin a new release. And yes, changes like this could
use community review.

Thanks
-- Mark

Nathan Scott wrote:
Hi,

It looks like the pcp start script (src/pmcd/rc_pcp) has been
changed post pcp-2.5.x to use the file /var/run/pcp/pmcd.pid
for decisions about whether pmcd is running or not.  Can you
send details about the problem being solved by this change?

Its causing problems on upgrades from current PCP versions to
the new version (2.7.x), because the old versions of pmcd do
not create this file and hence the sequence:

1. happily running pcp
2. upgrade pcp rpm
3. /etc/init.d/pcp start

causes a failure in the start script (the script thinks no
pmcd is running due to the pmcd.pid file not being found, so
does not do the "kill pmcd" step, spins in a loop for awhile
and eventually exits with ...

[root@nas2 pcp_install]# /etc/init.d/pcp start
Waiting for PMCD to terminate .........Process ...
2793
/etc/init.d/pcp: Warning: PMCD won't die!

(Its not that it wont die, its more that it hasn't been asked)


On a related note: Would it be possible for PCP changes to be sent out to the public list for review as well, before committal (as the SGI XFS guys do for their changes)? e.g. http://oss.sgi.com/archives/xfs/2007-05/msg00154.html http://oss.sgi.com/archives/xfs/2007-04/msg00112.html http://oss.sgi.com/archives/xfs/2007-04/msg00124.html

We'd appreciate it, and I know how difficult it can be to get
your code reviewed inside SGI sometimes ;)

cheers.


<Prev in Thread] Current Thread [Next in Thread>