Hi Lukas,
----- Original Message -----
> [...]
> The PAPI pmda has gone through a fair bit of work. The changes can be
Fabulous - awesome effort esp. on the QA front. I ran out of time to
review it all today (maybe someone else will?), but did sneak a quick
background QA run in on RHEL 6 today. I'm seeing a few new failures
there - see attached .bad files - any ideas on possible root causes?
Only other general piece of advice I can offer would be "release early,
release often" - the first commit here is >1 month old, and it probably
coulda been merged right away? *shrug* ... either way is fine, but I'd
go for quicker, smaller merges every day.
> [...]
> commit bc295db9a4e7b2bf5382b5b2cae3851b24829eac
> Author: Lukas Berk <lberk@xxxxxxxxxx>
> Date: Fri Sep 5 15:34:56 2014 -0400
>
> Add debug warning and return PM_ERR_CONV to papi.control.enable
>
> Currently papi.control.enable will just silently fail if presented
> with metrics it can't add, fix that.
>
> *src/pmdas/papi/papi.c - add debug warning and return the error in
> papi_store for enable
>
cheers.
--
Nathan
967.out.bad
Description: Binary data
903.out.bad
Description: Binary data
813.out.bad
Description: Binary data
799.out.bad
Description: Binary data
|