pcp
[Top] [All Lists]

Re: [pcp] [PATCH 0/6] nfsclient pmda

To: Max Matveev <makc@xxxxxxxxx>
Subject: Re: [pcp] [PATCH 0/6] nfsclient pmda
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Thu, 20 Oct 2011 11:47:03 +1100 (EST)
Cc: pcp@xxxxxxxxxxx, Ben Myers <bpm@xxxxxxx>
In-reply-to: <20126.20644.929776.493699@xxxxxxxxxxxx>

----- Original Message -----
> On Tue, 18 Oct 2011 15:08:28 -0500, Ben Myers wrote:
> 
> Max> - U32 for counts is probably a bit low - any particular reason
> Max> for not going U64?
> >>
> Nathan> What type is it in the kernel? (need to match - there's also
> Nathan> helper pmda_long and pmda_ulong types if thats what the kernel
> Nathan> is using)
> 
> bpm> Exactly. I used types to match those in the kernel. Hopefully I
> bpm> didn't overlook any.
> 
> Kernel is using ulong for the ops, transmissions and timeouts
> counters.
> 
> Nathan, how does pmda_ulong works? Is it smart enough to figure out
> difference between longs on 32 vs 64 bit platforms?

Yes (ignoring the little bug I just noticed) - it switches between 32/64
bit type based on sizeof([u]long) for the installed binary PMDA.so (so it
would be fooled by 32 bit binaries on a 64 bit system, but that's not how
we install things, by default).

cheers.

-- 
Nathan

<Prev in Thread] Current Thread [Next in Thread>