pcp
[Top] [All Lists]

pcp updates: misc small fixes, start qa vs coverity

To: PCP Mailing List <pcp@xxxxxxxxxxx>
Subject: pcp updates: misc small fixes, start qa vs coverity
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue, 7 Jan 2014 05:52:26 -0500 (EST)
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <1147802107.44740246.1389091937666.JavaMail.root@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: 23rJwF4Ep4s0VPCoDR5wBrArud3Mtw==
Thread-topic: pcp updates: misc small fixes, start qa vs coverity
Changes committed to git://oss.sgi.com/pcp/pcp.git dev

 configure                      |    6 +++---
 configure.in                   |    4 ++--
 man/man1/pmlogextract.1        |    2 +-
 qa/src/779246.c                |   36 +++++++++---------------------------
 qa/src/anon-sa.c               |    3 ---
 qa/src/arch_maxfd.c            |    4 ++++
 qa/src/archinst.c              |    6 +++---
 qa/src/badpmcdpmid.c           |    6 +++++-
 qa/src/chk_metric_types.c      |    4 ++--
 qa/src/chkacc4.c               |    6 +++---
 qa/src/chkopenlog.c            |    4 ++++
 qa/src/descreqX2.c             |   15 +++++++--------
 qa/src/dumb_pmda.c             |    2 +-
 qa/src/exercise.c              |   16 ++++++++--------
 qa/src/hex2nbo.c               |    4 ++--
 src/libpcp/src/access.c        |   27 +++++++++++++++------------
 src/libpcp/src/secureconnect.c |    2 +-
 src/pmcd/src/config.c          |   10 +++++-----
 18 files changed, 75 insertions(+), 82 deletions(-)

commit 4db836d604fbe2cac9452a6ac12a53357d854e91
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Jan 7 16:14:45 2014 +1100

    covscan: resolve benign warning re unused variable settings in qa test

commit 395cb20ab81b067bfedbec72c9301dab38d6267b
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Jan 7 16:09:33 2014 +1100

    covscan: resolve small memleak in qa test program exercise.c

commit 18f1978244e3babe38504345b2e896cc78ed8f7d
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Jan 7 16:06:38 2014 +1100

    covscan: check return code from __pmHandleToPtr in qa

commit 95f4386e3ed6722fbde3354607783e2025125639
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Jan 7 15:17:44 2014 +1100

    covscan: use the correct reporting routine for libpcp error codes

commit b3c6cab559a9e3356d6ee067653e6a21513c2cfd
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Jan 7 15:17:02 2014 +1100

    covscan: check return codes from new context and open

commit f6b613adaceb9381fba58f89c144589525bff516
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Jan 7 15:16:18 2014 +1100

    covscan: qa test code changes to ensure stack/vars always initd

commit 054e4fccbc739a90e474078b773fafb6182731a3
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Jan 7 15:10:01 2014 +1100

    Specify the NSPR flag to make getaddrinfo not resolve canonical hostname 
(unused)

commit 5127bff23841e1d7903e69d73645430377865f9c
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Jan 7 15:08:58 2014 +1100

    Second attempt at trying harder to resolve localhost, make libpcp like pmcd

commit 201dd6256a5db86e91c8352ba5a57f854928c846
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Jan 7 14:24:34 2014 +1100

    Revert "Try harder still to get a local host struct hostent"
    
    This reverts commit d9b54beb913016e7c989ad380cab5ee4c526ceb1.
    
    (Causes sigsegv with NSPR)

commit 3d92e962ea3f66931adf16f738774ef90200f236
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Jan 7 13:00:49 2014 +1100

    covscan: add error handling around a failed dup(2) call

commit 86d7aaa66c622064aa8677864cb7767378819d42
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Jan 7 12:57:50 2014 +1100

    covscan: fix issue in qa sa-sniffer tool, repeated fd close

commit 2a94d70afefd8c28ec8e5310e02f3d5733440942
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Jan 7 12:57:04 2014 +1100

    covscan: ensure pmidlist initialised in qa src program, cleanup

commit d9b54beb913016e7c989ad380cab5ee4c526ceb1
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Jan 7 12:54:11 2014 +1100

    Try harder still to get a local host struct hostent
    
    Will Cohen came across a failure to start pmlogger running locally
    [Mon Jan  6 15:13:24] pmlogger(23927) Error: __pmGetAddrInfo(santana), 
Unknown host
    [Mon Jan  6 15:13:24] pmlogger(23927) Error: Can't get host name/IP 
address, giving up
    
    It looks like this is another case of failure to resolve local
    addresses from local host names.  Documentation for getaddrinfo(3)
    states a null can be passed in for the "node" name (first param),
    so we now use this in cases where we know we're dealing with local
    name resolution, as a fallback.  Audit found a second similar-ish
    case over in pmcd, dealing with socket PMDA connections - make it
    use this same mechanism instead of hard coding "localhost".

commit 4d7b85b8534014a16b4f1f343b4e78fc3acf0b25
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Tue Jan 7 09:31:16 2014 +1100

    Fix the configure check for RHEL5 rpmlib

commit 342215f93078f69dbbbc8dd1cab5de8281c1613e
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Mon Jan 6 16:25:13 2014 +1100

    Fix typo on pmlogextract man page synopsis

<Prev in Thread] Current Thread [Next in Thread>
  • pcp updates: misc small fixes, start qa vs coverity, Nathan Scott <=