Re: [pcp] libvirt pmda: add per-device metrics

[Nathan Scott <nathans@xxxxxxxxxx>]

Hi Marko,

----- Original Message -----
> Hi,
> 
> Below is a patch to add support for per-device metrics (for
> VCPU/block/net devices). Nothing too exciting here, the only
> thing to pay attention to is that these clusters now have too
> different indoms, seems to work just fine.

Looks good, working nicely here.

> libvirt.domstats.block.capacity
>     inst [1 or "f01110aa-de20-4f2d-8f98-6ee0bc9de412-block7"] value 1073741824

There's a convention of using "::" as separator for compound instances in other
PMDAs, which would make the above -

  libvirt.domstats.block.capacity
      inst [1 or "f01110aa-de20-4f2d-8f98-6ee0bc9de412::block7"] value 
1073741824

Which is a more clear separator here, and its easier to pick apart in this case
too (via awk/sed/... that is).  If you have a strong preference for the original
way though, no problem going back to that - let me know.  Otherwise, its all in
now - thanks for following up on this.

cheers.

--
Nathan