Changes committed to git://oss.sgi.com:8090/nathans/kmchart.git
src/chart/source.cpp | 477
-------------------------------------------
src/chart/source.h | 101 ---------
src/chart/GNUmakefile | 2
src/chart/chart.cpp | 16 -
src/chart/chartdialog.cpp | 41 ++-
src/chart/chartdialog.h | 7
src/chart/kmchart.cpp | 2
src/chart/kmchart.pro | 4
src/chart/main.cpp | 31 --
src/chart/main.h | 5
src/chart/namespace.cpp | 5
src/chart/openviewdialog.cpp | 118 +++++++++-
src/chart/openviewdialog.h | 9
src/chart/openviewdialog.ui | 4
src/chart/source.cpp | 1
src/chart/source.h | 1
src/chart/tab.cpp | 6
src/chart/timecontrol.cpp | 6
src/chart/timecontrol.h | 2
src/chart/view.cpp | 16 -
src/dumptext/kmdumptext.cpp | 19 -
src/libqmc/qmc_group.cpp | 30 +-
src/libqmc/qmc_group.h | 14 -
src/libqmc/qmc_metric.cpp | 44 +--
src/libqmc/qmc_metric.h | 19 -
25 files changed, 252 insertions(+), 728 deletions(-)
commit aa53ec27dc8295e8b9606e76fc5cec1d87a2fd9b
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Mon Oct 8 08:40:32 2007 +1000
Change QMC to pass out the context from a group/metric as a real
pointer rather than a c++ reference, as this is what we really need
in kmchart. Rename which*() to context*() in the Group class,
as it makes the code more readable and consistent. Fixes SIGBUS
after New/Edit Chart dialogs have populated their tree views, as
we were mismanaging our group/metric state via references rather
than direct pointers (in particular group->context() was passing
back a copy of the QmcContext rather than a pointer to it).
commit b9c17e49a1f27b18013977a7d04ab71063c36387
Merge: 274ba58... 59dfaac...
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Sun Oct 7 14:47:44 2007 +1000
Merge leaf:/source/git/kmchart
commit 59dfaac271d67acc2ca353dd6fc29d4a00ec34b9
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Sun Oct 7 14:44:22 2007 +1000
This is a fairly major rework of the way we manage contexts in
kmchart. It completely removes the need for source.{h,cpp} as
we are now relying on all QmcContext data structure management
being done within the metrics class. Turns out the global list
of contexts, and current context pointers, that we maintained
in the Source class in kmchart were duplicating pointers and
lists that the metrics class was already maintaining. Output
from diffstat on this change says it all:
18 files changed, 170 insertions(+), 345 deletions(-)
So, this removes a bunch of code in kmchart, removes unneeded
data structure indirection, and fixes a context management bug
in the code that deals with selecting the new current context
(the bug was evident when multiple hosts were added into the
sourceComboBox, and then a chart was created with the second
or third, or fourth - it would still use the initial host as
the source of metrics).
There was some code in source.cpp dealing with user interface
updates (combo boxes, metric trees) - this has been moved to
the source files dealing with all other aspects of those parts
of the interface (where they really belonged anyway).
There is one remaining issue with the new/edit chart dialog I
still need to resolve due to this change, but lots is done and
I need to do an initial checkpoint commit now so I can context
switch temporarily.
commit 65013865720e0814ca68093dbcdcefaa6475e9cc
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Sun Oct 7 12:56:27 2007 +1000
Put kmchart config file in the default Qt location on all
platforms, else (on Unix variants) they interfere with the
User Views list as we get kmchart/Qt configs mixed up with
kmchart Views in ~/.pcp/kmchart then.
Also turn any additional arguments seen into whatever form
of source (archive/host) has been requested so far on the
command line (defaults to hosts).
commit b7c4d19c29c8be4d8c37eaae648035513a972424
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Sun Oct 7 12:52:34 2007 +1000
Remove unused fetchGroup field from Source struct.
commit da7b44400988dfcad8cd74f25b95fffef123e683
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Sun Oct 7 12:52:10 2007 +1000
Fix a typo in a debug statement.
|