Re: [pcp] pcp updates: Makepkgs --with-containers and associated build infrastructure

[Nathan Scott <nathans@xxxxxxxxxx>]

Hi Mark,

----- Original Message -----
> Changes committed to git://git.pcp.io/markgw/pcp/pcp.git master
> 

Looks good - I fixed a few typos, but nothing of interest.  Handful
of other small things worth considering...

- the Makepkgs --with-containers option maybe should be --with-docker
since its not useful for other container runtimes

- that option should be propagated through to configure, so that it
can verify all the necessary build toolchain is present - especially
the docker and dnf binaries that it needs (that version checking you
have in Makepkgs traditionally would live in configure.ac).

- the qa/admin/check-vm script should be updated for these tools and
their respective package names

- do we need a pcp-libs container layer between pcp-conf and friends?

I guess so, for people writing C monitoring tools in containers (need
libpcp), and/or instrumented applications (may need libpcp_mmv, etc)
in containers.

cheers.

--
Nathan