Re: [pcp] pcp updates: container/man build fix

[Nathan Scott <nathans@xxxxxxxxxx>]

Hi Lukas,

----- Original Message -----
> [...]
>  src/include/builddefs.in |    8 +++++++-
>  5 files changed, 23 insertions(+), 2 deletions(-)

Just this final chunk confuses me ...

 INSTALL_MAN = \
-    test -z "$$MAN_PAGES" && MAN_PAGES="$(MAN_PAGES)"; \
+    test -z "$$MAN_PAGES" && MAN_PAGES="$(MAN_PAGES)" && $(HAVE_MANPAGES); \
     for d in `echo $$MAN_PAGES`; do \

The added HAVE_MANPAGES there looks like a no-op, or is it needed in some
subtle way?  (note that final && is after a variable assignment).  Is the
intent perhaps to have a separate

+    test $(HAVE_MANPAGES) || MAN_PAGES=""; \

before the "for" loop?

cheers.

--
Nathan