pcp
[Top] [All Lists]

Re: [pcp] pmrep: improve vmstat example

To: myllynen@xxxxxxxxxx
Subject: Re: [pcp] pmrep: improve vmstat example
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Mon, 14 Dec 2015 00:01:34 -0500 (EST)
Cc: pcp developers <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <566D91D9.20900@xxxxxxxxxx>
References: <566D91D9.20900@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: 5qv0rUJnDR7gF6ela4LUVSSpSy+K/w==
Thread-topic: pmrep: improve vmstat example
Hi Marko,

----- Original Message -----
> Hi,
> 
> Mark showed how to get real percentages for different CPU usage
> categories, let's update the pmrep's vmstat example accordingly.
> 
> ---
>  src/pmrep/TODO       |  3 ++-
>  src/pmrep/pmrep.conf | 30 +++++++++++++++++++++---------
>  2 files changed, 23 insertions(+), 10 deletions(-)
> 

I just noticed we are not installing this pmrep.conf anywhere ...
(so its hard to QA test ;) - should we be?

Perhaps to /var/lib/pcp/config/pmrep/pmrep.conf or would a file
name more like "sample.conf" be more suitable?


diff --git a/src/pmrep/GNUmakefile b/src/pmrep/GNUmakefile
index e26f2e8..0543e31 100644
--- a/src/pmrep/GNUmakefile
+++ b/src/pmrep/GNUmakefile
@@ -27,6 +27,8 @@ include $(BUILDRULES)
 install: default
 ifeq "$(HAVE_PYTHON)" "true"
        $(INSTALL) -m 755 $(TARGET).py $(PCP_BIN_DIR)/$(TARGET)
+       $(INSTALL) -m 755 -d $(PCP_VAR_DIR)/config/pmrep
+       $(INSTALL) -m 644 pmrep.conf $(PCP_VAR_DIR)/config/pmrep/sample.conf
        @$(INSTALL_MAN)
 endif
 

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>