Re: [pcp] Relocation of Parfait

[Paul Smith <psmith@xxxxxxxxxx>]

On 2 Feb 2015, at 9:25 am, Nicholas Tindall <ntindall@xxxxxxxxxx> wrote:

Hi All,

I've cloned the new GitHub repo and put the bulk of my changes up there (for Dropwizard integration, https://github.com/nicktindall/parfait). I'll update the docs and give the code a once-over before I submit a pull request. Feel free to have a look and let me know if there's anything obviously missing/wrong.

Looks ok to me, and the proof is in the pudding, since you're running this in production... it would know better than I would...  I'd rather capture this as it is, if that's what you're using.  We can refine it later.

I'm planning to:

• Include a fluent builder in the ParfaitReporter similar to line 44 in https://github.com/dropwizard/metrics/blob/master/metrics-ganglia/src/main/java/com/codahale/metrics/ganglia/GangliaReporter.java. This seems to be a pattern that most other Reporter implementations adhere to.
• Add some documentation in the form of a README.md
• Maybe reconsider the inclusion of Metric name translation. The only reason I included it is because PCP doesn't like hyphens in metric names, which appear in some of the out of the box MetricSets that come with Dropwizard. I feel like it's not really a concern of the MetricAdapterFactory though.

All the above are lovely things, probably could be done as subsequent commits.  If you do a pull request of what you have, the Travis CI build should automatically test the Pull Request:

https://travis-ci.org/performancecopilot/parfait/pull_requests

I can merge it, and spin a new RC release into oss.sonatype.com, which you can change BIM to use, rather than the 'special' build you've made locally; makes it more hunky-dory legit.

Thanks Nick!

Paul