----- "Nathan Scott" <nscott@xxxxxxxxxx> wrote:
> ----- Forwarded Message -----
> From: "Olivier Tarnus" <o.tarnus@xxxxxxx>
> To: "Nathan Scott" <nscott@xxxxxxxxxx>
> Subject: Re: pmchart trackers
>
> Hi Nathan,
>
> I've been also hesitating a lot with the timeout, and thought it was
> the
> least intrusive for users that want to use the feature sporadically.
> I'll try to get it configurable.
Not sure what you mean by configurable there? What I was thinking of,
was clicking a chart to enable "tracker" mode, and clicking again to
switch it off (instead of click to enable, then timeout to disable).
Oh, did you mean do it both ways and choose via a configurable settings
dialog option? That'd work too, if so. Having used the timeout model
for selected values for awhile now though, I find it frustrating ... so
for me I'd only ever use the modal interaction, not the timeout.
> The good things with the time marker
> is
> that if we add multiple graphs per row, we still maintain a visible
> time
> position, and aligning the graphs with the time scale is less
> necessary.
*nod*
> I also still need to add a marker to the the time scale itself.
>
> I'll try now to add the options to the save/load functions. Also
> something is needed for the value markers, as they overlap most of the
> time. I thought about adding a special window that would list all
> values
> actually tracked in the same pmchart window.
Yeah, noticed that. Being able to set the plot Z value in some way
may be another approach there - currently this isn't configurable,
and it probably should be (iow, to set which plot shows up on top).
On the patch, the qDebug use was new to me - we should probably take
out Kens old Console class and replace it with this, much simpler.
The only other issues were the commented-out code, some still-TODO
bits of the code you'd noted, one or two headers re-introduced (like
QSplitter, IIRC) ... small stuff, looks good in general.
cheers.
--
Nathan
|