Changes committed to git://git.pcp.io/kenj/pcp master
Ken McDonell (9):
pmie: rework for string-valued metrics
sample PMDA: make sample.bin modifiable via pmstore
qa/867: add some more string-valued tests
configure: re-instate libsystemd-journal.so as fallback
qa/762.out: remade .out after metric sample.string.bin added
src/pmdas/sample/GNUmakefile: install executable and DSO PMDA binaries
sample PMDA: restore the values and instances for sample.bogus_bin
qa/075: changes after sample.bin became modifiable
qa/273,474&617: new .out after changes to sample PMDA help text
configure | 90 ++++++++++++++++++++++++++++++++++++++-
configure.ac | 8 +++
qa/075 | 12 ++++-
qa/075.out | 30 +++++--------
qa/273.out | 42 +++++++++++++++---
qa/474.out | 30 ++++++-------
qa/617.out | 14 +++++-
qa/762.out | 2
qa/867 | 26 +++++------
qa/867.out | 1
src/pmdas/sample/help | 14 +++++-
src/pmdas/sample/src/GNUmakefile | 1
src/pmdas/sample/src/sample.c | 55 +++++++++++++++++++----
src/pmie/src/dstruct.c | 28 +++++++++---
src/pmie/src/fetch.sk | 66 ++++++++++++++++++----------
src/pmie/src/misc.sk | 38 +++++++++++++---
src/pmie/src/syntax.c | 20 ++++----
17 files changed, 362 insertions(+), 115 deletions(-)
Details ...
commit 14f72469bc10908275d335d6c15437695d90f668
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Aug 16 08:14:52 2016 +1000
qa/273,474&617: new .out after changes to sample PMDA help text
More fallout from the sample.bin becomes modifiable change.
commit cc870954d0fe10a14993753c6321206dec345a9d
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Aug 16 08:13:22 2016 +1000
qa/075: changes after sample.bin became modifiable
Different expected results from pmstore, and (most importantly)
need to restore sample.bin at the end of the test to avoid cascaded
failures later.
commit 75b6f5acae4580a1bdb3837cc99f62365e4a38c8
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Aug 16 07:02:32 2016 +1000
sample PMDA: restore the values and instances for sample.bogus_bin
Got broken when I changed sample.bin to be modifiable via pmstore
and this was causing qa/058 failures.
commit 775bfe277426d801208717958ddf59e0501511ca
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Aug 16 06:59:07 2016 +1000
src/pmdas/sample/GNUmakefile: install executable and DSO PMDA binaries
The sample PMDA is designed to be built from source, but if the source
changes we and we re-install the package, then we may end up with
installed binaries that do not match the source ... and this can cause
QA failures.
Not sure why these were omitted from the install target, other than
possible to force checking that the PMDA can be rebuilt from the
package installed source, but that seems a stretch.
commit cbd9ed953f50b821a96bae4de91e899537ee6d6f
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Aug 15 21:47:39 2016 +1000
qa/762.out: remade .out after metric sample.string.bin added
commit 2fed1920bf2ad519409899e4965c36ef6d355516
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Aug 15 17:02:23 2016 +1000
configure: re-instate libsystemd-journal.so as fallback
For some older distros libsystemd.so is not available
(e.g. openSUSE 12.2), so the change commit 25d9bd6 means
we've gone from build the pcp-pmda-systemd rpm to not
building this rpm, which means the upgrade will fail.
This change maintains libsystemd.so as the preferred library
to check, but if that fails allows libsystemd-journal.so as
an alternative.
commit 0eb7db8855ba5702a1597bb7d676591adb2d7cc6
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Aug 14 20:29:58 2016 +1000
qa/867: add some more string-valued tests
commit 5245352185b5bdd840ddec62335e2762f2ca6487
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Aug 14 20:26:35 2016 +1000
sample PMDA: make sample.bin modifiable via pmstore
Needed for QA of some recent pmie changes. There are lots of
metrics that share the values behind sample.bin, so modifying
sample.bin["some instance"] changes the values for other metrics
as well, and in particular sample.string.bin["some instance"].
commit 81cb83e997458a705c004a65e9b4c60f8e1a21b5
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun Aug 14 11:31:15 2016 +1000
pmie: rework for string-valued metrics
1. fix problem with metric @N
2. as a result of 1. had to change from ring buffer pointers into
the pmResult, to ring buffer pointers to strdup()'d strings
(pmResults were being free'd before the expression evaluation
had finished with the values)
3. simplify and clarify some of the earlier code
|