Hi Lukas,
----- Original Message -----
> Hi,
>
> I've put together a library for use in extracting metric data from JSON
> files. Would love some feedback on it. I've replaced the JSON bits in
> pmdaroot and qa has remained consistent.
Neat! This is a great little abstraction - that pmdaroot docker code is
certainly cleaner now.
I've attached a man page page follow-up patch - some typos, some minor
wordsmithing - feel free to use/discard as you see fit.
There is some deb packaging work needed here - all shared libraries need
to be separate packages there, I'll help with that tomorrow. That makes
me wonder though - is this likely to expand in scope down the track? - I
can imagine lots of other www-related helper code needing a home - should
we name it more generically? - libpcp_web? (or something else, betterer).
Renaming it later will mean packaging pain, so ... maybe pre-empting that,
if you agree this might be needed later?
Oh, lastly - for a new shared library I think some qa/src code that takes
those interfaces through their paces would be good, instead of us solely
relying on the docker tests. The library is cross-platform, so test code
that runs on all platforms would be good. Simple stuff would suffice here
I think (theres some test data in qa/json/ already) - and maybe a valgrind
test too if you're feeling bold?
cheers.
ps: some of the build/configure/man-page stuff is still in that branch BTW.
--
Nathan
man.patch
Description: Text Data
|