Re: [pcp] [PATCH] pmda/memory_bandwidth: Add a new pmda to monitor the maximum memory bandwidth

[Nathan Scott <nathans@xxxxxxxxxx>]

Hi Hemant,

----- Original Message -----
> On 05/10/2016 08:38 AM, Nathan Scott wrote:
> > ----- Original Message -----
> >> [...] 
> > Other than those things, it all looks good to me - with some added QA and
> > docs as usual.
> 
> Cool, I just sent a v2 to the list. Thanks for the comments.
> 

I found we were a bit lacking in mem.* metrics in general, so I've added some
general testing and some specific testing to give us coverage here too.

Please have a look at tests 821 & 826 - there's still a bit to do, if you don't
mind taking that on.  It would be good to have some multi-node tests - so, we'd
need a new qa/linux/meminfo-root-002.tgz for that (and update to 821.out).  If
there's other unit cases missing from 826 in terms of config checking, please
go ahead & add some.

In terms of docs, I think it would be OK to document this metric (esp. config)
in its long form help text (src/pmdas/linux/help) - just a few words about the
format & the sample config file, how one might use the metric, and so on.

cheers.

--
Nathan