Hi Alec,
----- Original Message -----
> On Sun, Jul 03, 2016 at 11:02:21PM -0400, Nathan Scott wrote:
> > ----- Original Message -----
> > > [...]
> > > >> We've been testing it for a couple of days and have not had any issues
> > > >> with the patch.
> > > > The one thing the patch lacks is the influxdb equivalent of regression
> > > > test pcp/qa/667 which would take pcp2influxdb through its paces. Could
> > > > you add something like that little shell script, for influxdb?
> > > >
> > >
> > > I will certainly do this, but it'll take a few days. We are pretty busy
> > > getting ready for some maintenance that will happen in a couple of weeks.
> > >
> >
> > OK, thanks and no problem. Let me know if any assistance is needed there -
> > there's some high level notes about the test scripts in qa/README too.
> >
>
> I have added a test - qa/9001 - in the new version of the patch,
> attached to this mail. I did not want to pick a number in the low 1000's
> just in case it would be taken by now; that can be changed to whatever.
No problem - I renumbered to a nice memorable "1111" :) and added it into
the qa/group file.
> Sorry if that causes any trouble.
No trouble at all - we can also reserve test numbers in the qa/group file
if that helps (and others wont use them - the qa/new script skips 'em).
> Updates to qa/group and other metadata
> are not included in the patch so that it can be easily re-numbered.
All sorted. I've also added the debian/ubuntu packaging.
> The test that I added is not as full featured as qa/667. `socat' quits
> after receiving EOF, which makes it not useful for testing
> pcp2influxdb. pcp2influxdb aggregates metrics for a single request as
> much as possible, but two separate calls to Relay.send() will generate
> two separate connections. Without using another program or writing a
> little python HTTP server to use for testing, I wasn't sure how to add
> that to the test script.
S'OK - it looks like its still giving good coverage to me, and more cases
can be added over time as the need arises.
> In InfluxDB query language, "measurements" are similar to SQL tables and
> "fields" are similar to SQL columns.
Ah, interesting, good to know. Some of the comments in the code were very
informative too.
> If there's anything else - docs, bugs, etc. - I will of course be happy
> to take a look.
Everything looks fine to me, thanks Alec.
cheers.
--
Nathan
|