Re: [pcp] pcp updates: pmlogger semantics change, 1st round of strtoint64 changes

[Nathan Scott <nathans@xxxxxxxxxx>]

Hi Ken,

----- Original Message -----
> Some review eyes here would be appreciated.
> 

Looks good to me.  Couple of small things I noticed in passing...

diff --git a/src/include/pcp/config.h.in b/src/include/pcp/config.h.in
index 2d61bb0..18726bf 100644
--- a/src/include/pcp/config.h.in
+++ b/src/include/pcp/config.h.in
@@ -66,7 +66,7 @@ extern "C" {
 #define PRINTF_P_PFX "0x"
 #endif
 
-/* Determine the safest way to covert ascii to int64_t and uint64_t */
+/* Determine the safest way to convert ascii to int64_t and uint64_t */
 #undef strtoint64
 #undef strtouint64
 
diff --git a/src/pmlogger/src/gram.y b/src/pmlogger/src/gram.y
index 4bb16e6..4baf4f4 100644
--- a/src/pmlogger/src/gram.y
+++ b/src/pmlogger/src/gram.y
@@ -35,7 +35,7 @@
 int            mystate = GLOBAL;       /* config file parser state */
 
 __pmHashCtl    pm_hash;
-task_t         *tasklist = NULL;
+task_t         *tasklist;
 
 static task_t  *tp;
 static int     numinst;
@@ -131,6 +131,7 @@ dowhat              : logopt action
                            snprintf(emess, sizeof(emess), "malloc failed: %s", 
osstrerror());
                            yyerror(emess);
                        } else {
+                           task_t      *ltp;
 
                            /*
                             * Add to end of tasklist ... this means the
@@ -141,7 +142,6 @@ dowhat              : logopt action
                             * first, and clauses combined into the same
                             * task.
                             */
-                           static task_t       *ltp;
                            for (ltp = tasklist; ltp != NULL && ltp->t_next != 
NULL; ltp = ltp->t_next)
                                ;
                            if (ltp == NULL)