pcp
[Top] [All Lists]

Re: pmServiceDiscoveryInterrupt() commit a8b87e2 et al.

To: Dave Brolley <brolley@xxxxxxxxxx>
Subject: Re: pmServiceDiscoveryInterrupt() commit a8b87e2 et al.
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed, 9 Jul 2014 18:46:08 -0400 (EDT)
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <53BD8921.3000306@xxxxxxxxxx>
References: <20140619194444.3B03D58015@xxxxxxxx> <1374649635.181830.1404090114319.JavaMail.zimbra@xxxxxxxxxx> <53BC0D60.4000007@xxxxxxxxxx> <y0md2df8vse.fsf@xxxxxxxx> <53BC5248.5050100@xxxxxxxxxx> <256416707.6217487.1404883930815.JavaMail.zimbra@xxxxxxxxxx> <y0mpphe60bw.fsf@xxxxxxxx> <53BD8921.3000306@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: l269lCfTBZq1P7y/e5AfYGORqeVXLg==
Thread-topic: pmServiceDiscoveryInterrupt() commit a8b87e2 et al.
Hi Dave,

----- Original Message -----
> [...]
> My current felling is that we should stick with the string arguments and
> the interrupt flag and call it pmDiscoverServices1(1). While it seems
> likely that new options will be added to the API, it seems less likely
> that they will require another argument to be added and so I don't
> expect that we will be an explosion of versions. It is also consistent
> with the strategy chosen (and retained in all versions) of parsing
> options in the mechanism string.

I got the impression earlier that you were expecting more parameters to
be needed down the track, and that strings would not be ideal...? (like
the "interrupted" parameter).  If that's not the case and we can get
rid of that extra parameter, lets keep it simple and go back to strings
as you suggest.

That name is still really un-helpful though. :(  Please use something,
anything, other than a number (inconsistent with the rest of the PMAPI
and it says to the API user "I could not find words to describe this
thing").

In fact, double-underscore prefix is looking a really good option here
given the lack of certainty - please seriously consider that - we can
always add the PMAPI-level symbol later, once we've had more time to
consider and see what else comes up.

So, pick one of the above two approaches please, and if not settled on
a direction you're happy with by weeks end, lets yank this code and try
again next release?

Thanks mate.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>