Re: additional metrics for elasticsearch PMDA

[Ryan Doyle <rdoyle@xxxxxxxxxx>]

Hey dude,

Got a problem running it. This is the output from the logs:

$ cat elasticsearch.log

Log for pmdaelasticsearch on app4 started Thu Mar 21 10:17:35 2013

Odd number of elements in anonymous hash at /var/lib/pcp/pmdas/elasticsearch/pmdaelasticsearch.pl line 128.

Odd number of elements in anonymous hash at /var/lib/pcp/pmdas/elasticsearch/pmdaelasticsearch.pl line 131.

Use of uninitialized value in anonymous hash ({}) at /var/lib/pcp/pmdas/elasticsearch/pmdaelasticsearch.pl line 131.

On #pcp at the moment if you want to work through it.

Cheers

----
Ryan Doyle

---

From: "Nathan Scott" <nathans@xxxxxxxxxx>
To: "Ryan Doyle" <rdoyle@xxxxxxxxxx>
Cc: pcp@xxxxxxxxxxx
Sent: Thursday, 21 March, 2013 10:04:48 AM
Subject: Re: additional metrics for elasticsearch PMDA

Hi Ryan,

----- Original Message -----
>
> Hi Nathan/others
>
> Please see new patch - just disregard the previous one. This now
> transposes the results hash and "renames" the problematic key values
> so it can be easily accessed with es_value subroutine.
>

Yep, I think this approach is much better.  I found I couldn't follow
the remapping code easily though, mainly because of the repeated hash
lookups.  I refactored it slightly to avoid those, and now it makes a
bit more sense to me - can you take a look?

Once I could see the forest for the trees, I noticed a redundant check
on $content being defined too, so removed that.  In dev now, so please
have a look for me and let me know if still works (no ES test setup).

cheers.

--
Nathan